Fix vip app
#2144
Merged
Fix vip app
#2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore support for format for the command, otherwise we never end up outputting anything. Also removes the redundant `header` handling which would include extrenuous data in the output.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
|
sjinks
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore support for format for the command, otherwise we never end up outputting anything. Also removes the redundant
headerhandling which would include extrenuous data in the output.See #2129
Fixes BB8-12202
Steps to Test
npm run build./dist/bin/vip-app.js./dist/bin/vip-app.js api<= output as table./dist/bin/vip-app.js api --format json<= output as json./dist/bin/vip-app.js api --format csv<= output as CSV